Migrate to use repo-config #124
Conversation
llucax
commented
Jul 3, 2023
llucax
commented
- Migrate to use repo-config
- Fix some typing issues in src/conftest.py
- Clear release notes
github-actions
bot
added
part:docs
| # Preview controls | ||
| watch: | ||
| - src | ||
| - "src" |
There was a problem hiding this comment.
Why does src get quotes and the rest not?
There was a problem hiding this comment.
Because it is generated via a template and since we don't know the content 100% sure, we quote it. We don't need to have the inconsistency though, but it should be reported in repo-config, as the template should be fixed and then this repo updated via the template.
|
In your commit description:
->
|
Marenz
left a comment
Marenz
left a comment
There was a problem hiding this comment.
I found a few minor things, I'll leave it up to you whether they should be ifxed
pyproject.toml
Outdated
| "mkdocs-gen-files == 0.5.0", | ||
| "mkdocs-literate-nav == 0.6.0", | ||
| "mkdocs-material == 9.1.17", | ||
| "mkdocs-material == 9.1.16", |
There was a problem hiding this comment.
Oversight, the templates are outdated. I think it will be very annoying to keep templates up to date, so I thought it was better to just leave the projects to get updated via dependabot. But of course when migrating/updating a project we shouldn't revert dependencies, so I will fix, thanks!
Now this project uses repo-config: https://github.com/frequenz-floss/frequenz-repo-config-python The files were updated by generating the project using the cookiecutter template. Some dependencies needed to be upgraded as part of the process. Now all dependencies are pinned and kept at the pyproject.toml file. Signed-off-by: Leandro Lucarella <[email protected]>
These errors went unnoticed in the past because the file wasn't being checked by `mypy`. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
When building the documentation with mkdocs we are actually using repo-config to generate the API documentation, so we need to add it to the dependencies. Signed-off-by: Leandro Lucarella <[email protected]>
Thanks! Will fix the typo but I will leave the quotes to be fixed in repo-config. |
|
Updated! |
|
Enabled auto-merge. |
3 participants
